Closed
Conversation
…te file - Updated PURL-related tests to assert only the HTTP 302 status and Location header, without following the redirect to the BioPortal UI. This avoids triggering Cloudflare bot protection during CI runs. - We do not want to test UI behavior here — we only verify that the correct redirect is served by the PURL resolver. Testing how the UI handles or rewrites URLs (e.g., with query parameters or concept ID fragments) is out of scope for these tests. - Split PURL resolution tests into a new file `test_class_purl.rb` to separate concerns from core class model tests in `test_class.rb`.
Member
I'm not sure I'm following this comment. These unit tests weren't added to test UI behavior. They were added because the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid following PURL redirects and split PURL tests into a separate file
Updated PURL-related tests to assert only the HTTP 302 status and Location header,
without following the redirect to the BioPortal UI. This avoids triggering
Cloudflare bot protection during CI runs.
We do not want to test UI behavior here — we only verify that the
correct redirect is served by the PURL resolver. Testing how the UI handles or
rewrites URLs (e.g., with query parameters or concept ID fragments) is out of scope
for these tests.
Split PURL resolution tests into a new file
test_class_purl.rbto separateconcerns from core class model tests in
test_class.rbResolves Unit test fails in GitHub Actions due to Cloudflare bot protection — proposal to test only PURL redirect header #41